build(ci): lock @lhci/cli in the lockfile and test the summary script - #94
Merged
Merged
Conversation
Pin @lhci/cli 0.15.1 as a devDependency so the Lighthouse job runs the lockfile-verified binary via `pnpm exec lhci autorun` instead of fetching it unverified with `pnpm dlx` on every run. The job already installs with --frozen-lockfile before this step. No new dependency needs a build script, so the allowBuilds gate is unchanged. Refs #87 Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
Run scripts/lighthouse-summary.mjs in a child process against fake *.report.json files: odd-count median, even-count median as the mean of the two middle values, exit 1 with a message for a missing or empty reports folder, and the table appended to GITHUB_STEP_SUMMARY. Replacing the even-count mean with the lower middle value fails the even case. Refs #87 Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
Dreamcoder08
added a commit
that referenced
this pull request
Sep 29, 2026
* test(console): accumulate sessionStorage restores in chunk-recovery tests setSessionStorage overwrote a single module-level restore, so a test that swapped storage twice lost the first restore. Restores now stack and run newest first in afterEach. Refs #92. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf * test(convergence): drive the pointer-idle teardown test with mock timers The test waited 260ms of real time; it now enables node:test mock timers and ticks past the idle timeout, so it is deterministic and instant. Refs #92. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf * test(terminal): tighten the TERMINAL-003 chromium-only guard Keep the skip as the first statement, set apart from the page work, and stop restating the Chromium navigation rationale in two comments. Titles and tags are unchanged. Refs #93. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf * test(ci): run the lighthouse-summary child with a hermetic env The child inherited the whole parent env minus GITHUB_STEP_SUMMARY; it now gets only PATH plus what each test passes, so CI variables such as NODE_OPTIONS cannot leak in. Also make the table-row helper easier to read. Refs #95. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87.
@lhci/cli0.15.1 is now a lockfile-covered devDependency; the workflow runspnpm exec lhci autoruninstead ofpnpm dlx.scripts/lighthouse-summary.mjs(odd/even median, missing folder, empty folder, step summary).Unit 196/196, check, format and size budgets green locally; the Lighthouse job proves the workflow change.
https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf