Plan #35 follow-up: sealed subclass scope wording + closure recovery - #37
Merged
Merged
Conversation
Applies plan #35's recorded round-1 code-review advisory: Kotlin 1.5+ permits sealed direct subclasses anywhere in the same package and module, not the same compilation unit; multiplatform projects also require the same source set. Content hash re-synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Applies plan #35's recorded round-1 code-review advisory: Kotlin 1.5+ permits
sealeddirect subclasses anywhere in the same package and module (not the same compilation unit); multiplatform projects also require the same source set. Content hash re-synced.This PR also restores #35's merged-closing-PR proof: the original closure by PR #36 was displaced when the issue was reopened to repair a non-terminal step record, and
plan.mjs archivetrusts only the latest closure event.Reviews: code review round 2
pass(one new LOW advisory recorded on the issue - expect/actual source-set nuance, follow-up candidate).Verification:
node scripts/ci.mjs --plugin docksexit 0.