Harden author-side payload gating - #34
Merged
Merged
Conversation
Implements the reviewed plan #33: - no-author-scripts matcher derives author tails from the on-disk scripts/ inventory and flags them under any prefix, with no exemption logic; bundled plugin-internal scripts never match because their filenames are not author tails - declared skills/agents roots that are missing now fail the gate instead of silently skipping - agent-scorer output is corroborated: exit status, row names vs on-disk agents, duplicates, non-finite scores, empty-root vacuity; seven-case unit suite registered as unit-agent-score-vacuity - ci-plugin-targeting stub scorer aligned with the real scorer's stripped-name output (fixture drift exposed by the new corroboration) Closes #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Implements the reviewed plan #33:
scripts/skills/no-author-scripts.mjsderives author-script tails from the on-diskscripts/inventory at runtime and flags them under any prefix (bare,./,../, variables, command substitutions, alternate clone roots) with no exemption logic; bundled plugin-internal scripts (write-skill/scripts/skill-guard.mjs, plan-lifecyclescripts/plan.mjs) never match because their filenames are not author tails.unit-agent-score-vacuity..md-suffixed names the real scorer never emits; aligned (drift exposed by the new corroboration).CLAUDE_PLUGIN_ROOTis a compatibility alias forPLUGIN_ROOT; shipped hook files unchanged.Reviews: plan review rounds 1-3
repair(tail derivation, doc-grounded hook step, test-contracts registration), round 4pass; code review round 1fixes-required(HIGH: prefix exemption bypass, fixed by deleting the exemption), round 2pass.Verification: full
node scripts/ci.mjsexit 0; six evasion spellings fail the guard and the bundled reference passes;unit-agent-score-vacuity7/7; targeting contracts green.