Plan lifecycle: disambiguate the phase 6 commit-before-block sentence - #30
Merged
DocksDocks merged 1 commit intoAug 24, 2026
Merged
Conversation
…tence The phase 6 item said "Before any terminal review block, commit and normally push all current work" - readable as commit-before-any-verdict (pass included), contradicting the after-pass landing rule it sits beside. Reword to name the two stop conditions exactly: "Before recording a technical block or terminal repair failure". Pins the corrected sentence in the phase tests and refuses the old phrase; re-syncs the plan-workspace content hash. Closes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Implements the reviewed plan #29:
docs/PLAN.mdand the workspace template, removing the parse that demanded a commit before apassverdict.scripts/tests/plan-skill-phases.mjsasserts the corrected sentence in both files and fails if "terminal review block" returns.Reviews: plan review round 1
repair(selftest attribution), round 2pass; code review round 1passwith no findings.Verification: phase tests, plugin selftest,
scripts/ci.mjs --plugin plan-lifecycle, and fullscripts/ci.mjsall exit 0 with preserved exit codes.