Plan lifecycle: harden CLI writes and validation - #26
Merged
DocksDocks merged 1 commit intoAug 24, 2026
Conversation
Implements reviewed plan #23: - claim/new verify the assignee by post-write read; claim's assignee write is guarded body-unchanged - retire retries on a closed not-planned issue with a stale phase label and finishes cleanup; fully retired plans stay refused - new prevalidates a trimmed 1-70 title and non-empty goal before any write - machine-path citations catch any POSIX absolute, drive-letter, and UNC path, backticked included; link destinations and exactly /dev/null exempt - status/step/claim refuse malformed v3 records via the full 13 checks Code review round 1: pass with two recorded MEDIUM advisories (phase-label post-read set check; /dev/null token exactness and bare drive roots). Closes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Implements the reviewed plan #23:
claim's assignee write is body-unchanged guarded;newandclaimverify by post-write read that the acting login is the sole assignee, refusing silent assignment failures.plan:<phase>label skips the close, finishes label cleanup, and exits 0; fully retired plans stay refused./dev/nullstay exempt;/dev/shm/...is refused.status,step, andclaimrun the full 13-check validation and refuse malformed v3 records without writing.Reviews: plan review round 1
repair(root allowlist replaced by full POSIX detection), round 2pass; code review round 1passwith two recorded MEDIUM advisories (phase-label post-read set check;/dev/nulltoken exactness + bare drive roots) left as follow-up, reviewed bytes unchanged.Verification:
scripts/tests/plan-cli.mjs,plan-skill-phases.mjs, plugin selftest,scripts/ci.mjs --plugin plan-lifecycle, and fullscripts/ci.mjsall exit 0.