fix(plan-lifecycle): accept merged PullRequest ClosedEvent closer in archive - #25
Merged
Merged
Conversation
…archive GitHub classifies some same-repository keyword closers as user-linked and returns an empty excludeUserLinked connection, while the ClosedEvent closer arrives as a PullRequest node rather than a Commit. archive ignored that closer and refused a legitimately merged closing pull request (observed live on #22). Read the PullRequest closer from the timeline and verify it with the same merged-into-default-branch rule; an unmerged or wrong-branch closer is still refused.
…t, template, and PLAN.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #22
plan.mjs archiverefused the legitimately merged closing PR on live GitHub: theexcludeUserLinkedconnection came back empty for a same-repository keyword closer, and the ClosedEvent closer arrived as aPullRequestnode, which the verifier ignored (Commitonly). Observed live while archiving #22.PullRequestcloser from the timeline and verify it with the existing merged-into-default-branch rule.Verification:
plan-clicontract suite andscripts/ci.mjs --plugin plan-lifecycleexit 0; liveplan.mjs archive 22now printsplan #22 finished (closed by …/pull/24).