Plan lifecycle: comment-backed reviews, bounded repair loops, implement-start branch - #24
Merged
DocksDocks merged 1 commit intoAug 24, 2026
Conversation
…mplement-start branch Move review records from the issue body to trusted issue comments: one unchanged reviewer block per comment, sole-assignee author trust, latest trusted record per review kind, legacy body fallback only when no trusted comment exists. Replace the one-repair-re-review dead-end with bounded five-round repair loops in both review phases, with commit-and-push before any technical block so implementation work is never stranded. Create and verify the issue's linked branch at implement start via repository-scoped gh issue develop, gated on a clean worktree, with no local fallback. Mirror the settled wording across the contract, skills, wrappers, templates, repo docs, public descriptors, and verbatim phase tests. Closes #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Implements the reviewed plan #22:
plan.mjs showsurfaces per-kind verdicts;archiverequires the latest trustedCode-review: pass.plan.mjs status <issue> ongoing, the manager requires a clean worktree, then verifies/creates the issue's linked branch via repository-scopedgh issue develop(--repo,--base <default> --checkout), with failure recovery and no local fallback. Plan-only runs never create a branch.Verification:
plan-skill-phases,plan-cli, plugin selftest, and the fullscripts/ci.mjsgate all exit 0. Code review: round 1fixes-required(2 HIGH, both repaired), round 2pass— records on #22.