Skip to content

Plan lifecycle: comment-backed reviews, bounded repair loops, implement-start branch - #24

Merged
DocksDocks merged 1 commit into
mainfrom
22-plan-lifecycle-implement-branch-review-loop-comment-records
Aug 24, 2026
Merged

Plan lifecycle: comment-backed reviews, bounded repair loops, implement-start branch#24
DocksDocks merged 1 commit into
mainfrom
22-plan-lifecycle-implement-branch-review-loop-comment-records

Conversation

@DocksDocks

Copy link
Copy Markdown
Owner

Closes #22

Implements the reviewed plan #22:

  • Review records move to issue comments. Each reviewer returns one parser-compatible block; the manager posts it unchanged as one issue comment. Trust requires the comment author to equal the plan's sole assignee; the latest trusted record per review kind wins, with legacy body fallback only when no trusted comment of that kind exists. plan.mjs show surfaces per-kind verdicts; archive requires the latest trusted Code-review: pass.
  • Bounded repair loops replace the one-repair dead-end. Both review phases run at most five rounds on fresh inputs; rounds 1-4 repair every named finding; the loop terminates on no progress, a surviving finding, or a round-5 non-pass. Any terminal failure after implementation starts commits and pushes current work before the plan blocks.
  • Linked branch at implement start. After plan.mjs status <issue> ongoing, the manager requires a clean worktree, then verifies/creates the issue's linked branch via repository-scoped gh issue develop (--repo, --base <default> --checkout), with failure recovery and no local fallback. Plan-only runs never create a branch.
  • Synchronized mirrors. Contract, three skills, four reviewer wrappers, workspace templates, root AGENTS.md, docs/PLAN.md, both READMEs, all three public descriptors, and the verbatim phase tests carry the same wording; the Codex code-reviewer wrapper now inlines the parser-compatible record grammar.

Verification: plan-skill-phases, plan-cli, plugin selftest, and the full scripts/ci.mjs gate all exit 0. Code review: round 1 fixes-required (2 HIGH, both repaired), round 2 pass — records on #22.

…mplement-start branch

Move review records from the issue body to trusted issue comments: one
unchanged reviewer block per comment, sole-assignee author trust, latest
trusted record per review kind, legacy body fallback only when no trusted
comment exists. Replace the one-repair-re-review dead-end with bounded
five-round repair loops in both review phases, with commit-and-push before
any technical block so implementation work is never stranded. Create and
verify the issue's linked branch at implement start via repository-scoped
gh issue develop, gated on a clean worktree, with no local fallback.
Mirror the settled wording across the contract, skills, wrappers, templates,
repo docs, public descriptors, and verbatim phase tests.

Closes #22
@DocksDocks DocksDocks linked an issue Aug 24, 2026 that may be closed by this pull request
@DocksDocks
DocksDocks merged commit 733d58e into main Aug 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan lifecycle: implement branch, review loop, comment records

1 participant