Skip to content

feat(plan-lifecycle)!: bound reviews and default PR landing - #21

Merged
DocksDocks merged 2 commits into
mainfrom
fix/review-verdict-convergence
Aug 21, 2026
Merged

feat(plan-lifecycle)!: bound reviews and default PR landing#21
DocksDocks merged 2 commits into
mainfrom
fix/review-verdict-convergence

Conversation

@DocksDocks

Copy link
Copy Markdown
Owner

What changed

  • Bound code-review convergence to one repair re-review while allowing advisory-only passes.
  • Default routine plan publication and passed-review landing to commit, normal push, and a closing pull request.
  • Require a fresh two-choice confirmation only before default-branch merge.
  • Verify one merge-base candidate, pull-request diff parity, CI policy, and the reviewed head SHA.

Review order

  1. 4b11871 implements the separately reviewed issue Make code-review pass cover advisory-only rounds #18 convergence contract.
  2. 6aafb47 implements the reviewed issue Complete the reviewed lifecycle landing cutover #20 landing cutover and plan-review repair.

Verification

  • node scripts/tests/plan-skill-phases.mjs
  • node scripts/ci.mjs

Closes #18
Closes #20
Refs #19

Advisory findings should not force repair rounds, while repeated high-impact failures need a deterministic stop. Define the verdict threshold and pin both reviewer wrappers so contract drift fails CI.

Refs #18
Routine plan publication and post-review branch landing no longer require repeated approval. Preserve one explicit user boundary immediately before default-branch merge, and pin the complete candidate, CI, and head-SHA safeguards.

Refs #20
@DocksDocks
DocksDocks merged commit 9bdda07 into main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete the reviewed lifecycle landing cutover Make code-review pass cover advisory-only rounds

1 participant