feat(plan-lifecycle)!: bound reviews and default PR landing - #21
Merged
Conversation
Advisory findings should not force repair rounds, while repeated high-impact failures need a deterministic stop. Define the verdict threshold and pin both reviewer wrappers so contract drift fails CI. Refs #18
Routine plan publication and post-review branch landing no longer require repeated approval. Preserve one explicit user boundary immediately before default-branch merge, and pin the complete candidate, CI, and head-SHA safeguards. Refs #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Review order
4b11871implements the separately reviewed issue Make code-review pass cover advisory-only rounds #18 convergence contract.6aafb47implements the reviewed issue Complete the reviewed lifecycle landing cutover #20 landing cutover and plan-review repair.Verification
node scripts/tests/plan-skill-phases.mjsnode scripts/ci.mjsCloses #18
Closes #20
Refs #19