Skip to content

Feat/testcoverage - #1379

Merged
yusuftomilola merged 4 commits into
DistinctCodes:mainfrom
nafsonig:feat/testcoverage
Aug 27, 2026
Merged

Feat/testcoverage#1379
yusuftomilola merged 4 commits into
DistinctCodes:mainfrom
nafsonig:feat/testcoverage

Conversation

@nafsonig

Copy link
Copy Markdown
Contributor

Linked issues

Closes #1311

Checks

  • Lint passes for every area touched
  • Build passes
  • Tests pass
  • No secrets, keys, or .env values are committed
Contract changes only — expand if this PR touches contracts/

Run from contracts/:

cargo fmt --all -- --check
cargo clippy --all-targets --all-features -- -D warnings
cargo test --all

Confirm the sections that apply to this change:

  • Authorization — every new or modified state-changing entrypoint calls
    require_auth() on the correct principal, and no entrypoint treats a
    caller-supplied address argument as proof of identity. Negative tests
    exist without mock_all_auths.
  • Arithmetic — no unchecked arithmetic on any path handling amounts,
    shares, or percentages; overflow returns a typed error.
  • Storage and TTL — correct durability chosen, and persistent entries
    that must outlive the default are extended.
  • Pause — new mutating entrypoints respect the pause guard.
  • Admin and upgrades — privileged entrypoints are admin-gated and emit
    an event.
  • Events — every new state change emits an observable event, and the
    event catalogue is updated.
  • Size — WASM size impact considered for new dependencies or large code
    additions.

If this PR knowingly leaves one of these open, say which and why:

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@nafsonig is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@yusuftomilola yusuftomilola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge conflicts with main. Good test coverage additions - approving.

@yusuftomilola
yusuftomilola merged commit 9dada46 into DistinctCodes:main Aug 27, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FE-116] ui/csv.tsx has no test coverage

2 participants