Feat/testcoverage - #1379
Merged
Merged
Conversation
|
@nafsonig is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
approved these changes
Aug 27, 2026
yusuftomilola
left a comment
Collaborator
There was a problem hiding this comment.
No merge conflicts with main. Good test coverage additions - approving.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Closes #1311
Checks
.envvalues are committedContract changes only — expand if this PR touches
contracts/Run from
contracts/:cargo fmt --all -- --check cargo clippy --all-targets --all-features -- -D warnings cargo test --allcontracts/SECURITY.mdConfirm the sections that apply to this change:
require_auth()on the correct principal, and no entrypoint treats acaller-supplied address argument as proof of identity. Negative tests
exist without
mock_all_auths.shares, or percentages; overflow returns a typed error.
that must outlive the default are extended.
an event.
event catalogue is updated.
additions.
If this PR knowingly leaves one of these open, say which and why: