Repository navigation
Release equivalence slice: drop test_preset_loader.py, guard the slice against denied presets (#2749) - #2750
Merged
Merged
Conversation
v0.66.0's verify failed on tests/test_preset_loader.py (9 FileNotFoundError: devto, bluesky, hashnode, denied by #2734); nothing was published. The file leaves the slice; a new test reads the slice from release-branch.yml and the dropped presets from release-branch.json and fails on any overlap (red first, on that file). Slice re-run locally inside the built tree: 184 passed. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2749
What
The v0.66.0 tag (80d7343) failed
verifyinrelease-branch.yml: the step that proves the stripped tree behaves like the source runstests/test_preset_loader.py, which loadsdevto,blueskyandhashnode, denied from the directory build by #2734. 9FileNotFoundError,publishskipped, nothing published (releasestill v0.65.1).tests/test_preset_loader.pyleaves the slice. It pins test-modulesys.pathisolation, not runtime behaviour of the stripped tree; it still runs in the normal suite.tests/test_release_equiv_slice_2749.pyreads the slice out ofrelease-branch.ymland the dropped presets out ofrelease-branch.json, and fails on any overlap. Red first ({'tests/test_preset_loader.py': ['bluesky', 'devto', 'hashnode']}), with a positive control on that file. It runs on every PR, which is the point: the slice itself only runs on a tag (release-branch.yml checks the directory tree only on a v* tag: a PR that breaks it is found at release #2743).Verified
The slice, reproduced locally exactly as the workflow runs it (built tree from 80d7343,
tests/copied in,-o addopts="", same two deselects): before,9 failed, 185 passed, the same 9 as CI; after,184 passed.After merge
No retag. Dispatch the workflow from master with
ref=v0.66.0: master's workflow file and tests, the tree built from the tag.🤖 Generated with Claude Code
[AI-generated]