Skip to content

chore: curate trap.d -- 2 awk gotchas promoted, 7 fragments declined - #479

Merged
fdaviddpt merged 1 commit into
mainfrom
curate/20261006T123436Z
Oct 6, 2026
Merged

fdaviddpt merged 1 commit into
mainfrom
curate/20261006T123436Z

Conversation

@fdaviddpt

Copy link
Copy Markdown
Contributor

Curate pass over trap.d/ (#1670/#1723 procedure). 9 fragments read together, each decided on its own merits.

Promoted (2)

Both merged into .claude/jit-context/paths/00-manual/hooks.md's existing "one awk trap, measured on both engines" section -- they are the same class of lesson (an awk-writing gotcha specific to common.sh/common-awk.sh), so a reader already in that section finds them beside their siblings rather than in a new file.

No match pattern changed on either merge (body text only, into an already-firing file), so no new firing proof is needed and rebuild-tsv.sh was not run.

Declined, already fixed (2)

Declined, still true -- filed (4)

Each checked against HEAD (bda0282) before filing, per the decline-of-a-code-claim rule:

Declined, agent-facing lesson (1)

  • trap.d/437.wrong-worktree-edits.md -- forgetting a per-call cd <worktree> && prefix. Not promoted: no ERE can distinguish "this call already has a same-call cd prefix" from "it does not" (no lookbehind in this awk dialect), so the only matchable rule would fire on every edit/paste/batch call in the whole repository, correctly-prefixed ones included. The supertool write op's own [branch: ...] receipt already names where a write landed, checkable after the fact on exactly the calls that need it.

Disagree with any of this

Say so on the PR -- every decision above is a sentence, not a verdict, and this pass has no standing to insist on any of them.

trap.d/ ends this pass empty (README.md only). Nothing deferred.

[AI-generated]

Promoted two awk-writing lessons (dynamic-regex backslash-doubling in
bracket expressions, #432; `in` as a silently-compiling reserved-word
parameter name, #442) into paths/00-manual/hooks.md's existing
awk-trap section.

Declined the remaining seven fragments, each with a citation per
paths/00-manual/00-README.md's own decline-line rule: two already
fixed by e0f8d39 (#437/#438) (#424 jit-misses.sh, half of #424
rebuild-tsv.sh), one still-live half of that same #424 fragment
(layerdir/bytesof(), filed #475), three more still-live test/workflow
defects filed as #476/#477/#478, one already fixed in PRIVACY.md by
#468/#470 (#466), and one agent-facing lesson (#437, wrong-worktree
edits) whose mitigation already exists as the supertool write op's
own [branch: ...] receipt.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@fdaviddpt fdaviddpt added the no-changelog Change is invisible to users label Oct 6, 2026
@fdaviddpt

Copy link
Copy Markdown
Contributor Author

Maintainer review (tick wait+review step, skills/manager/phases/review.md):

Content: clean. Both promoted lessons (dynamic-regex bracket escaping, in as a reserved word) are well-sourced, body-text-only edits into hooks.md's existing awk-trap section -- no match pattern changed, so no rebuild-tsv.sh run needed, consistent with the PR's own claim. The four declined, still true items were each checked against HEAD before filing (#475-#478), all carry filed-by-loop + a lane + a priority label. Blast radius matches the description exactly (trap.d/ deletions, two 00-README.md additions, hooks.md addition).

CI finding (below-bar, not this diff's fault): the one real failure -- hooks (windows-latest, shard 2/4), job #112276374977 -- is test-run-all-timing.sh's FAIL: the slower suite is listed before the faster one (slow_line=10 fast_line=9). This diff touches only trap.d/ and two 00-manual docs, nothing under tests/ or tests/run-all.sh, so the failure is unrelated to this PR's content: a tie-break flake where the fixture's "slow" (sleep 1) and "fast" suites rounded to the same integer wall-clock second on a loaded Windows runner, making the slowest-first sort order ambiguous. Not blocking this release by the ranking table in skills/manager/phases/findings.md (a test-harness tie-break, not a shipped-code defect) -- recorded here as the receipt rather than filed as an issue. Re-run the failed leg before merge; the fragment leg shown as superseded/cancelled is expected (a later run of the same name superseded it, per pr_green.py).

Decision: content ready-to-merge; merge blocked only on a green re-run of the windows hooks shard-2/4 leg.

@fdaviddpt
fdaviddpt merged commit d476bf0 into main Oct 6, 2026
19 of 24 checks passed
@fdaviddpt
fdaviddpt deleted the curate/20261006T123436Z branch October 6, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Change is invisible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant