Fixed issue #1194, with unit tests - #1195
Open
VladimirChumakov wants to merge 1 commit into
Open
VladimirChumakov wants to merge 1 commit into
VladimirChumakov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1194
Problem
Custom SOAP headers in incoming messages get corrupted by SoapCore before being passed to registered IMessageInspector2 in AfterReceiveRequest call.
Fix
The fix is in ParsedMessageHeader.cs file, OnWriteHeaderContents method where the attributes are now written with a namespace prefix, if known, otherwise falls back to the existing functionality.
Tests
Tests are in src\SoapCore.Tests\Serialization\Issue1194 folder, and test both Soap 1.2 and 1.1 messages.
The new tests fail before the fix and pass after.
The rest of the test suite is unaffected.