Repository navigation
fix(i18n): load textdomain on init (Issue #5) - #7
Merged
Merged
Conversation
Avoid early get_plugin_data translation on plugins_loaded and register load_plugin_textdomain on init (priority 0). Adds TextdomainLoadingTest regression coverage for GitHub Issue #5.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Unblocks QA Plugin Check after Issue #5; keep intentional load_plugin_textdomain on init for GitHub-distributed installs.
Christian-Devora
added a commit
that referenced
this pull request
Nov 5, 2026
Christian-Devora
added a commit
that referenced
this pull request
Nov 5, 2026
* chore(mat): refresh sidecar via mat-sync rebootstrap Sync MAT workflow assets from upstream (source-config v2, docs, scripts, selective .cursor tracking) while leaving product PHPUnit WIP unstaged. * fix(qa): use named Docker volume for local PHPUnit MySQL Persist the MySQL datadir across container recreate and document that the script never deletes Docker volumes. * docs: close out Issue #5 plan after PR #7 merge and local deploy * fix(mat): ignore live .mat.env and env credential files Close Codex PR #6 finding 1: gitignore/cursorignore live secrets while keeping samples tracked; doctor and phase1 green on the slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_textdomain_just_in_timeforrank-math-api-managerby reading plugin headers withget_plugin_data( …, false, false )and loading the textdomain oninit(priority 0).TextdomainLoadingTestregression coverage (TDD RED→GREEN).Test plan
php -lon touched PHP files./scripts/run-phpunit-local.sh(9 tests, 54 assertions, 1 skipped)gh act -j php-lint --container-architecture linux/amd64WP_DEBUG