Repository navigation
chore(mat): refresh sidecar via mat-sync rebootstrap - #6
Conversation
Sync MAT workflow assets from upstream (source-config v2, docs, scripts, selective .cursor tracking) while leaving product PHPUnit WIP unstaged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d3546706f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !**/.env.sample | ||
| .cursor/mcp.json |
There was a problem hiding this comment.
When an operator follows .mat.env.sample and copies it to .mat.env, the live configuration is neither gitignored nor excluded by .cursorignore. The sample explicitly describes it as gitignored and provides fields for observability authentication tokens, but git check-ignore -v --no-index .mat.env finds no matching rule. Consequently, routine staging or Cursor indexing can include credentials that operators reasonably expect to remain private. Add explicit exclusions for .mat.env while keeping .mat.env.sample tracked. .mat/AGENTS.mat.mdL506-L506
Useful? React with 👍 / 👎.
| bootstrap|rebootstrap) | ||
| log "phase gate: running bootstrap (${route})" | ||
| MULTI_AGENT_WORKFLOW_ROOT="${mat_source}" bash "${BOOTSTRAP_SCRIPT}" \ | ||
| --mode existing-project \ | ||
| --non-interactive \ | ||
| "${TARGET_ROOT}" |
There was a problem hiding this comment.
If the configured upstream branch advances between planning and approval, source resolution fetches the newer revision before phase_gate, and this branch executes its bootstrap script without checking the approved plan's resolved_sha. Comparing the approved JSON with latest-plan.json only verifies the saved documents, not the source being applied. I reproduced this with a local upstream: a plan recording revision v1 executed the v2 bootstrap after upstream advanced. Pin bootstrap/rebootstrap to the recorded SHA, or reject approval when the resolved source differs, so approval cannot install unreviewed workflow changes.
Useful? React with 👍 / 👎.
Persist the MySQL datadir across container recreate and document that the script never deletes Docker volumes.
…v ignore branch
Close Codex PR #6 finding 1: gitignore/cursorignore live secrets while keeping samples tracked; doctor and phase1 green on the slice.
Codex review follow-upFinding 1 ( Finding 2 ( Also merged |
|
Upstream issue filed for Finding 2: https://github.com/Devora-AS/multi-agent-workflow/issues/10 |
Summary
/mat-update-mat→mat-sync(routing: rebootstrap;true_drift: 0).mat/source-config.jsonv2, refreshed.mat/docs/scripts, and opted into selective.cursor/tracking (agents/commands/hooks/rules/skills)CONTRIBUTING.md/AGENTS.mdfor the new.cursor/policy; left product PHPUnit WIP unstagedTest plan
bash scripts/doctor.shPASS (post-approve)bash scripts/phase1-verify.shOK (adopted-operational).cursor/mcp.json, hook state,__pycache__)