Repository navigation
Conversation
Contributor
|
LOD checks when build mode.. lod one sec draws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure how to test these two fixes specifically, but the module compiles and runs in game with OG/AE.
BGSAIWorldLocationRefRadius (
AdModuleBGSAIWorldLocationRefRadius.cpp)rsiis the address of theNiPointer<TESObjectREFR>&.rsiis a reference,test rsi, rsichecks the wrong thing.cmp qword[rsi], 0, which tests the _ptr.LODDistance (
AdModuleLODDistance.cpp)0xEBpatch moves fromREL::ID(2197513)+0x5BtoREL::ID(2213411)+0x64.REL::ID(2197513)+0x5BisBGSMod::Attachment::Mod::GetFilterChance.REL::ID(2213411)+0x64is the visibility lambda inBGSDistantObjectBlock::UpdateInstanceVisibility.REL::Offset(0x52A80)(xor eax,eax; ret) is replaced withREL::ID(1425899), so it resolves through Address Library. The old RVA was in the middle ofBGSModand was a getter, the new one isSetVisibleDistant. This aligns OG to what the NG/AE patch was doing.ThisVirtualCall(5-arg overload) (Core/AdUtils.h)a4twice (a1, a2, a3, a4, a4, a5), soa5landed in the wrong slot.a1..a5once each.