Image to Text (pixel) Convertor - #61
Conversation
Silabear
left a comment
Silabear
left a comment
There was a problem hiding this comment.
Good overall, but my hyper-detail brain thinks there are some minor things to consider
There was a problem hiding this comment.
im not entirely sure about whether the design of this fits with the rest of the site, it feels kinda clunky now with the padding. i think maybe something can be done to improve this (e.g. having the delete/use button have the same style as the rest of the site, and putting both the renderer + buttons in a visible container)
There was a problem hiding this comment.
it might make sense to add a warning or limit to the image size. the minecraft chat can only really render images of a certain size, and i tried to upload a random image I had lying around and it took AGES for it to load in the editor. ik there is some text there already but there should be a hard limit, or at least a visual warning if you upload a file thats too big
There was a problem hiding this comment.
actually thank you so much, this was causing some problems in my other branch <33
There was a problem hiding this comment.
There is no problem with this, but its worth noting that this toolbar is getting insanely long now. We might have to collapse the colours into a dropdown-like thing in order to fit this all in. On some computer screens this will deffo wrap around, which isnt ideal
| background-color: #45454e80; | ||
| border: solid #45454e 1px; | ||
| border-bottom: solid #9448e0 2px; | ||
| padding-bottom: 4px; |
There was a problem hiding this comment.
this mark has 4px bottom padding but the other mark has none. i think 4px is too much but none is weird esp with underlined text too, so maybe both should be 2px?
There was a problem hiding this comment.
the reason the paddings are misaligned is to make sure both show when applied, if both are applied and have the same padding, then they will overlap and it will be ambiguous what is applied on first glance
There was a problem hiding this comment.
is there any way to stack them but only when both are applied at the same time? that makes sense but its still annoying when they are side by side
There was a problem hiding this comment.
I'll look into it
…ure/image-conversion
…e is too large, fix some issues with the save menu
Deploying tools with
|
| Latest commit: |
bc3de10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://838ad3d2.tellraw-aav.pages.dev |
| Branch Preview URL: | https://feature-image-conversion.tellraw-aav.pages.dev |
2 participants
This PR adds a image to text pixel conversion, along with a few smaller fixes and improvements to the save menu