Repository navigation
fix: wire LiveKit redis from Dependencies.Redis secretRef - #1
Merged
Merged
Conversation
Embedded redis:6379 stays empty when HA Redis is external; hostNetwork LiveKit then crashloops. Parse the resolved redis URI into livekit.yml. Co-authored-by: Cursor <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0dbadb4. Configure here.
| fmt.Fprintf(b, " username: %s\n", user) | ||
| } | ||
| if pass != "" { | ||
| fmt.Fprintf(b, " password: %s\n", pass) |
There was a problem hiding this comment.
Unquoted Redis credentials break YAML
Medium Severity
writeLiveKitRedis writes Redis username and password into livekit.yml as raw unquoted scalars. A credential that starts with #, *, !, &, |, or {, or that contains a colon-space, yields invalid YAML, so LiveKit fails to load config. Nearby node_ip already uses quoted YAML.
Reviewed by Cursor Bugbot for commit 0dbadb4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Dependencies.RedisURI (secretRef/inline) instead of hard-codedredis:6379harbor.dataknife.net/library/stoat-operator:9bdea64-lkredisTest plan
Running/ready, LiveKit1/1on prd after operator rollMade with Cursor
Note
Medium Risk
Changes LiveKit runtime Redis connectivity; mis-parsed URIs or bad secrets could still break voice pods, but the change mirrors an existing, tested dependency resolution path.
Reviewed by Cursor Bugbot for commit 0dbadb4. Bugbot is set up for automated code reviews on this repo. Configure here.