Skip to content

Refactor savetables function to exit early for 0 rows #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iodwyer wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −19
Open

Refactor savetables function to exit early for 0 rows #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions code/wdb/writedown.q
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,34 @@ tabsizes:([tablename:`symbol$()] rowcount:`long$(); bytes:`long$()); /- ke

savetables:{[dir;pt;forcesave;tabname]
/- check row count
/- forcesave will write flush the data to disk irrespective of counts
if[forcesave or maxrows[tabname] < arows: count value tabname;
arows:count value tabname;
.lg.o[`rowcheck;"the ",(string tabname)," table consists of ", (string arows), " rows"];
/- upsert data to partition
.lg.o[`save;"saving ",(string tabname)," data to partition ", string pt];
.[
upsert;
(` sv .Q.par[dir;pt;tabname],`;.Q.en[hdbsettings[`hdbdir];r:0!.save.manipulate[tabname;`. tabname]]);
{[e] .lg.e[`savetables;"Failed to save table to disk : ",e];'e}
];
/- make addition to tabsizes
.lg.o[`track;"appending table details to tabsizes"];
.wdb.tabsizes+:([tablename:enlist tabname]rowcount:enlist arows;bytes:enlist -22!r);
/- empty the table
.lg.o[`delete;"deleting ",(string tabname)," data from in-memory table"];
@[`.;tabname;0#];
/- run a garbage collection (if enabled)
if[gc;.gc.run[]];
:1b;
]; 0b};

/- exit early if 0 row count, return 0b for no changes to table
if[0 = arows;:0b];

/- forcesave will write flush the data to disk irrespective of counts
if[forcesave or maxrows[tabname] < arows;
/- upsert data to partition
.lg.o[`save;"saving ",(string tabname)," data to partition ", string pt];
.[
upsert;
(` sv .Q.par[dir;pt;tabname],`;.Q.en[hdbsettings[`hdbdir];r:0!.save.manipulate[tabname;`. tabname]]);
{[e] .lg.e[`savetables;"Failed to save table to disk : ",e];'e}
];
/- make addition to tabsizes
.lg.o[`track;"appending table details to tabsizes"];
.wdb.tabsizes+:([tablename:enlist tabname]rowcount:enlist arows;bytes:enlist -22!r);
/- empty the table
.lg.o[`delete;"deleting ",(string tabname)," data from in-memory table"];
@[`.;tabname;0#];
/- run a garbage collection (if enabled)
if[gc;.gc.run[]];
:1b;
];
:0b
};


\d .
/-endofperiod function
Expand Down