Skip to content

refactor(generated): move scaffold into generated directory - #830

Merged
MintsInc merged 1 commit into
DataDog:mainfrom
MintsInc:ulysse.mavrocordatos/AAWF-1386/move-generated-scaffold
Sep 16, 2026
Merged

MintsInc merged 1 commit into
DataDog:mainfrom
MintsInc:ulysse.mavrocordatos/AAWF-1386/move-generated-scaffold

Conversation

@MintsInc

Copy link
Copy Markdown
Member

Summary

Move the generated-command scaffold into an isolated directory for generated modules.

Changes

  • Move src/generated.rs to src/generated/mod.rs
  • Update the scaffold comment to describe generated modules within the directory
  • Keep the existing mod generated; integration and CLI behavior unchanged

This layout keeps generated command modules out of the crate root and separate from hand-written modules under src/commands/. Moving the existing scaffold also prevents src/generated.rs and src/generated/mod.rs from coexisting and causing Rust error E0761.

Testing

  • cargo build
  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test -- --test-threads=1 — 2,003 passed
  • Confirmed pup --help contains no generated subcommand
  • Browser WASM build not run locally because the wasm32-unknown-unknown target is unavailable

Move the generated-command registry to src/generated/mod.rs so future generated modules can live in an isolated directory without conflicting with hand-written commands.
@MintsInc
MintsInc marked this pull request as ready for review September 16, 2026 13:08
@MintsInc
MintsInc requested a review from a team as a code owner September 16, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants