Repository navigation
test(libdd-data-pipeline-ffi): remove redundant trace exporter builder tests - #2838
Draft
VianneyRuhlmann wants to merge 2 commits into
Draft
VianneyRuhlmann wants to merge 2 commits into
VianneyRuhlmann wants to merge 2 commits into
Conversation
…mirroring the Rust builder Add a ddog_trace_exporter_builder_* FFI that maps 1:1 onto TraceExporterBuilder, alongside the existing ddog_trace_exporter_config_* API which is now deprecated (Rust #[deprecated] plus a portable DDOG_TRACE_EXPORTER_DEPRECATED macro in the generated header; behavior unchanged). - enable-only setters for health metrics, stats and client-computed stats/headers; enable_stats takes a bucket interval in seconds - ddog_trace_exporter_builder_build consumes the builder, including on error - new C types: ddog_ExporterTelemetryConfig (2 fields), ddog_ExporterTagList, ddog_ExporterHeader(List) for Vec-based builder methods; telemetry enable and instrumentation sessions are separate bindings - parity: 47 of 48 builder methods bound (build_async is not representable; the 2 stats-obfuscation-gated ones are excluded because cbindgen does not evaluate #[cfg]) - migrate examples/ffi/trace_exporter.c to the builder API
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: abd6db0 | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes redundant tests from
libdd-data-pipeline-ffi/src/trace_exporter/builder/tests.rson top of #2689:legacy_boolean_setters_still_support_disablingandlegacy_exporter_new_does_not_consume_config(legacy config API).exporter_send_check_rate_test, which duplicatesexporter_send_empty_array_test(same build → send → rate-response path; the kept test also asserts request headers).Motivation
Keep one test per behavior in the new builder FFI test suite.
Additional Notes
This branch is based on
vianney/remove-config-in-ffi(#2689), so againstmainthe diff also includes that PR's commits; the change specific to this PR is the last commit.How to test the change?
Run locally:
cargo nextest run -p libdd-data-pipeline-ffi builder::: 20 passed.cargo +stable clippy -p libdd-data-pipeline-ffi --all-targets -- -D warnings: clean.