Encode telemetry as dogstatsd-http metrics. - #320
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c9a94293e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| * @param prefix Metric name prefix. | ||
| */ | ||
| public void encodeTo(String prefix, PayloadBuilder pb) { | ||
| long ts = intervalStartMillis / 1000; |
There was a problem hiding this comment.
Whenever a snapshot is taken after construction or a previous snapshot, intervalStartMillis predates the queue state and age values, which are sampled using the current time in snapshot(). Using that interval start for every point therefore backdates queue_*, oldest_enqueued_age_seconds, and last_success_age_seconds; with infrequent snapshots, these gauges can appear substantially stale or be rejected as out-of-window data. Store the snapshot/end wall-clock time and use it for these point-in-time metrics.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is consistent with general dogstatsd behavior, where point timestamp is the start of the time interval covered by it.
2 participants
No description provided.