fix: preserve PHP 7.1 ZTS property names - #4185
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Benchmarks [ tracer ]Benchmark execution time: 2026-09-11 03:13:31 Comparing candidate commit e1e74cc in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 189 metrics, 0 unstable metrics.
|
Description
Fixes a crash that happens during shutdown on PHP 7.1 on ZTS builds. This is happening a lot on the combined tracer+profiler branch, and I wanted it to get reviewed and merged independently since that PR is so big already, and it's not related to the branch.
Common symptom is:
Which happens in
tsrm_shutdown.Reviewer checklist