Light cleanup and rule adds

[colin-higgins]

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34be4ff192

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Preserve the final newline when regenerating API stubs

When make generate_stubs is run, tooling/stubs/generate-stubs.php writes the printer output directly, and that output currently omits the final newline—as evidenced by the generated src/ddtrace_php_api.stubs.php needing a manual newline in this commit. Because this ruleset scans that file, regeneration will now make ci-lint fail until someone manually restores the newline. Update the generator or printer to append it before enabling this rule.

Useful? React with 👍 / 👎.

[datadog-datadog-prod-us1-2]

 

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 7 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | appsec integration tests: [test8.4-release-zts] — ❌ 51 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

❌ POST request sets content type and length() from com.datadog.appsec.php.integration.FrankenphpClassicTests

Assertion failed: 

assert span.meta['http.request.headers.content-type'] == 'application/json'
       |    |   |                                     |
       |    |   null                                  false
       |    ['http.status_code':'200', 'http.endpoint':'/hello.php', '_dd.p.ksr':'1', 'span.kind':'server', '_dd.p.dm':'-1', 'http.url':'http://docker:32773/hello.php', 'runtime-id':'8413179e-2792-4fbc-83b5-93140822a03d', 'env':'integration', 'http.method':'POST', 'http.useragent':'Java-http-client/17.0.20']
       com.datadog.appsec.php.model.Span@22361e23

Assertion failed: 

...

❌ [1] file_get_contents, 19 from com.datadog.appsec.php.integration.FrankenphpClassicTests

Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':542936.0, '_dd.agent_psr':1.0, 'php.compilation.total_time_ms':0.149, 'php.memory.peak_real_usage_bytes':2097152.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@57b711b6

Assertion failed: 

...

❌ [1] file_put_contents, /tmp/dummy, 9 from com.datadog.appsec.php.integration.FrankenphpClassicTests

Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':541032.0, 'php.compilation.total_time_ms':0.147, '_dd.agent_psr':1.0, 'php.memory.peak_real_usage_bytes':2097152.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@8b89b3a

Assertion failed: 

...

❌ [2] fopen, 16 from com.datadog.appsec.php.integration.FrankenphpClassicTests

Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':503896.0, '_dd.agent_psr':1.0, 'php.compilation.total_time_ms':0.0, 'php.memory.peak_real_usage_bytes':2097152.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@5bbf744b

Assertion failed: 

...

❌ [2] readfile, /tmp/dummy, 15 from com.datadog.appsec.php.integration.FrankenphpClassicTests

Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':485528.0, 'php.compilation.total_time_ms':0.0, 'php.memory.peak_real_usage_bytes':2097152.0, '_dd.agent_psr':1.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@7be7c052

Assertion failed: 

...

↳ and 46 more — View all

DataDog/apm-reliability/dd-trace-php | check libxml2 version — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | helper-rust integration coverage — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 7 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 55.03% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 34be4ff | Docs | View more details | Give us feedback!}

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2026-09-10 22:25:07

Comparing candidate commit 34be4ff in PR branch colin.higgins/enable-more-checks with baseline commit 774e243 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

• 🟩 = significantly better candidate vs. baseline
• 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:SamplingRuleMatchingBench/benchRegexMatching1

• 🟥 execution_time [+126.547ns; +202.253ns] or [+8.893%; +14.213%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

• 🟥 execution_time [+98.557ns; +171.443ns] or [+6.799%; +11.828%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

• 🟥 execution_time [+116.122ns; +178.678ns] or [+8.026%; +12.350%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 execution_time [+118.883ns; +196.517ns] or [+8.312%; +13.740%]