fix appsec int tests fail on frankenphp - #4182
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
morrisonlevi
left a comment
There was a problem hiding this comment.
Looks good to Claude, and it does fix the tests it aims to. I don't quite grasp it, but the way it makes it portable is instead of patching away glibc symbols, it builds them on musl to begin with. Something like that.
Sorry, I gave a truncated explanation, but to be clear what fixes it is to build ddappsec against a patched musl. With some previous toolchains, doing so would leave a NEEDED entry in the ELF for the musl shared library's explicit name, which would have to be patched away with patchelf in order to load it on glibc. However, the new toolchain doesn't require this anymore for reasons not worth going into. So I removed the step that would do the patching as well. |
Description
After the appsec image upgrade, the builds of ddappsec.so started targeting a version of glibc too recent for the frankenphp image.
Reviewer checklist