Skip to content

drop qemu and parallelize jobs - #171

Merged
ojproductions merged 3 commits into
mainfrom
onzia/fix-slow-ci
Oct 28, 2026
Merged

ojproductions merged 3 commits into
mainfrom
onzia/fix-slow-ci

Conversation

@ojproductions

@ojproductions ojproductions commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Build arm64 on a native ARM runner (ubuntu-24.04-arm), and keep amd64 on ubuntu-24.04. drop the QEMU install and its overhead
  • Matrix the four Ruby versions so they run in parallel

Motivation

this check size build took 2h 43 m. This is too long.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@ojproductions
ojproductions marked this pull request as ready for review October 27, 2026 18:03
@ojproductions
ojproductions requested review from a team as code owners October 27, 2026 18:03

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The matrix preserves all eight Ruby/architecture combinations, and the aggregate check-size job requires every build to succeed. The completed static review found no actionable regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 7417ddb

@ojproductions ojproductions changed the title split check size job into parallel builds drop qemu and parallelize jobs Oct 27, 2026
@lucaspimentel

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T18:58:21.396950Z 39b9a38 Manual request
🔒 Security Review ✅ Completed 2026-10-27T18:59:40.087616Z 39b9a38 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 39b9a38ad7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 39b9a38ad7

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0787843 | Docs | Give us feedback!

Comment thread .github/workflows/check-size.yml Outdated

@lucaspimentel lucaspimentel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from @purple4reina's comment about pinning Ubuntu version

@ojproductions
ojproductions enabled auto-merge (squash) October 28, 2026 02:50
@ojproductions
ojproductions merged commit 5a09d3e into main Oct 28, 2026
52 of 65 checks passed
@ojproductions
ojproductions deleted the onzia/fix-slow-ci branch October 28, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants