Skip to content

stop pinning tracer version when building layer - #151

Open
ojproductions wants to merge 4 commits into
mainfrom
onzia/unpin-tracer
Open

ojproductions wants to merge 4 commits into
mainfrom
onzia/unpin-tracer

Conversation

@ojproductions

@ojproductions ojproductions commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

dont pin the tracer version. Allow minor version upgrades

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@ojproductions
ojproductions marked this pull request as ready for review October 22, 2026 22:30
@ojproductions
ojproductions requested review from a team as code owners October 22, 2026 22:30

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

Automatic tracer upgrades will fail integration checks because the log snapshots still require version 2.46.0. The existing normalization pipeline preserves this field, so even a patch-version change produces a mismatch.

Open Bits AI session

🤖 Bits Code Review · Commit e65916d

Comment thread Dockerfile
# NOTE: datadog gem must be >= 2.24 to install on Ruby 4.0.x.
MAKEFLAGS="-j$(nproc)" \
gem install datadog -v 2.40 --install-dir "/opt/ruby/gems/$runtime" --no-document; \
gem install datadog -v '~> 2.40' --install-dir "/opt/ruby/gems/$runtime" --no-document; \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Normalize the tracer version before allowing automatic upgrades

When an automatic upgrade selects a tracer version other than 2.46.0, integration checks fail because all log snapshots require that exact CORE configuration version. The normalization pipeline leaves this field untouched; changing only the version to 2.46.1 reproduces the mismatch. Normalize the field and regenerate the affected snapshots so compatible upgrades can pass.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 just add some normalizer for the version number

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants