Repository navigation
stop pinning tracer version when building layer - #151
ojproductions wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Automatic tracer upgrades will fail integration checks because the log snapshots still require version 2.46.0. The existing normalization pipeline preserves this field, so even a patch-version change produces a mismatch.
🤖 Bits Code Review · Commit e65916d
| # NOTE: datadog gem must be >= 2.24 to install on Ruby 4.0.x. | ||
| MAKEFLAGS="-j$(nproc)" \ | ||
| gem install datadog -v 2.40 --install-dir "/opt/ruby/gems/$runtime" --no-document; \ | ||
| gem install datadog -v '~> 2.40' --install-dir "/opt/ruby/gems/$runtime" --no-document; \ |
There was a problem hiding this comment.
Normalize the tracer version before allowing automatic upgrades
When an automatic upgrade selects a tracer version other than 2.46.0, integration checks fail because all log snapshots require that exact CORE configuration version. The normalization pipeline leaves this field untouched; changing only the version to 2.46.1 reproduces the mismatch. Normalize the field and regenerate the affected snapshots so compatible upgrades can pass.
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
There was a problem hiding this comment.
+1 just add some normalizer for the version number
What does this PR do?
dont pin the tracer version. Allow minor version upgrades
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply