Skip to content

👷 Use workspace:* protocol for internal monorepo dependencies - #5016

Merged
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/workspace-protocol
Sep 7, 2026
Merged

👷 Use workspace:* protocol for internal monorepo dependencies#5016
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/workspace-protocol

Conversation

@BenoitZugmeyer

Copy link
Copy Markdown
Member

Motivation

Internal @datadog dependencies were hardcoded to the exact release version (e.g. 7.11.0, 0.0.12) in every package.json. This requires updating all of them on each release and causes avoidable merge conflicts on release branches.

Changes

  • Switched all internal @datadog/* dependencies in packages/*/package.json (dependencies, devDependencies, and peerDependencies) from hardcoded versions to Yarn's workspace:* protocol.
  • Updated the checkBrowserSdkPackageJsonFiles CI check to assert internal dependencies use workspace:* instead of matching a concrete version, and removed the now-unneeded independentVersions map (js-core is now also referenced via workspace:*).
  • Regenerated yarn.lock (registry resolutions replaced by pure workspace references).

workspace:* resolves to the local package version at install time and is rewritten to the concrete version when publishing to npm (yarn workspaces foreach ... npm publish in publish-npm.ts), so published artifacts are unaffected.

Test instructions

  • Run yarn install and confirm it resolves cleanly from workspaces.
  • Run yarn typecheck.
  • Verify with yarn pack --dry-run on a package (e.g. packages/browser-rum) that the packed package.json shows concrete versions, not workspace:*.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 182.02 KiB 182.02 KiB 0 B 0.00%
Rum Profiler 8.43 KiB 8.43 KiB 0 B 0.00%
Rum Recorder 25.32 KiB 25.32 KiB 0 B 0.00%
Logs 57.96 KiB 57.96 KiB 0 B 0.00%
Rum Salesforce N/A 140.08 KiB N/A N/A N/A
Rum Slim 140.08 KiB 140.08 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%
Rum Shopify N/A 206.82 KiB N/A N/A N/A
Rum-shopify Profiler N/A 8.43 KiB N/A N/A N/A
Rum-shopify Recorder N/A 3.74 KiB N/A N/A N/A

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.01% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e8ca3cb | Docs | View more details | Give us feedback!

Internal @DataDog dependencies were pinned to the exact release version in
every package.json, requiring all of them to be updated on each release and
causing merge conflicts on release branches.

Switch to Yarn's workspace:* protocol, which resolves to the local package
version at install time and is rewritten to the concrete version when
publishing to npm.
@BenoitZugmeyer
BenoitZugmeyer force-pushed the benoit/workspace-protocol branch from cf9d0e8 to e8ca3cb Compare September 4, 2026 13:26
@BenoitZugmeyer

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T14:47:34.903473Z e8ca3cb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: e8ca3cb04e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenoitZugmeyer
BenoitZugmeyer marked this pull request as ready for review September 4, 2026 14:44
@BenoitZugmeyer
BenoitZugmeyer requested review from a team as code owners September 4, 2026 14:44
@BenoitZugmeyer
BenoitZugmeyer merged commit 691d99d into main Sep 7, 2026
31 checks passed
@BenoitZugmeyer
BenoitZugmeyer deleted the benoit/workspace-protocol branch September 7, 2026 07:54
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants