Repository navigation
Feat: Publish letify-link to crates.io and re-export it from letify - #107
Merged
Merged
Conversation
# Conflicts: # letify-core/Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conclusion: a tag now publishes two crates, letify-link then letify, and
letify::linkre-exports the whole of letify-link. Nothing was published or tagged by this change.letify::link(plusVERSIONand arelayfeature that enablesletify-link/relay), the publish order and the checks.publish = falseand gains readme, homepage, documentation, keywords, categories, a README and a LICENSE. letify depends on it withversion = "=3.0.3"andpath.scripts/version.pyreads, checks and sets the=<version>pin inletify-core/letify/Cargo.toml, sosetand the CI version check keep it in step (tests/test_version.py).scripts/publish-crates.shlists the crates whose version is not yet on crates.io and runs onecargo publish -p letify-link -p letify --locked, which orders the upload and waits for the index. Dry run is inverify, upload stays last. A crate already on crates.io is skipped, so a rerun after a failed upload publishes only what is missing.Evidence:
cargo test -p letifyfailed withcannot find link in letify, and 3 tests in tests/test_version.py failed, before the feature commit. Both pass after it.cargo fmt --all --check,cargo clippy --workspace --all-targets --all-features --locked -- -D warnings,cargo test --workspace --lockedandpytest tests/test_version.pypass locally.cargo publish -p letify-link -p letify --locked --dry-runpackages, verifies and builds letify against the packaged letify-link, without that version on crates.io.scripts/publish-crates.sh --dry-runskips letify 3.0.3 (already on crates.io) and dry-runs letify-link.cargo package -p letify-link --list: 61 files, 855.9 KiB (211.9 KiB compressed), no target directory.