Repository navigation
Chore: Build the Windows renderer kit in release mode - #850
Merged
Merged
Conversation
windows-static.yml ran build-windows.sh with no flag, so konanc compiled the Windows renderer with -g and without -opt, and that debug build was packaged as the windows-x64 release asset. The macOS and Linux kits have always been built with --release. Nothing says debug was meant: the script got an optional --release when it was written and the workflow was added without it. A debug Kotlin/Native build has larger frames, which is part of why a deep tree overflowed the 1 MB main-thread stack on Windows, and it is slower than what the other platforms ship. The job's time with -opt is not known yet; this branch is for measuring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-static.ymlranbuild-windows.shwith no flag, so the Windows renderer was a Kotlin/Native debug build (konanc-g, no-opt), and that build was the windows-x64 release asset. The macOS and Linux kits are built--release. Nothing says debug was meant: the script got an optional--releasewhen it was written and the workflow was added without it.Evidence, batch run 43744965586 (this commit together with #845 and #684): the kit job passed in release mode (about 17 minutes with the mingw Compose cache warm), and
windows_static_consumer,test_native_renderer,test_samplesandpackage_windows_hostare green against it. Effect measured by the consumer job's deep-tree step: a 1 MB stack holds a tree 50 levels deep with the release kit, where the debug kit overflowed at 25.Leader decision 2026-11-16: its own branch, dispatched with the stack fix.