Repository navigation
Fix: Write the smoke host's measure requests at the record's real length (PR-2.1) - #809
Merged
Merged
Conversation
…gth (PR-2.1) The measure request record grew from 72 to 80 bytes when the font features went into it (#788, FR-83). The smoke host writes its requests by hand in C and kept 72, so the renderer read the second, third and fourth request of the round trip eight, sixteen and twenty-four bytes early, and the smoke test failed on every platform with "the measure round trip did not agree, or never ran" (develop CI run 43617787436: iOS simulator, GraalVM Linux and macOS, Windows). MEASURE_RECORD is 80. The records are zeroed before they are filled, so the new font features slot reads as none. scripts/tests/smoke-host-measure-record.test.sh holds the C length equal to MEASURE_RECORD_LEN; it fails on the old value.
Since 1.11.1-ext.4 (fork #167) the fork's desktop modules (ui-desktop, foundation-desktop and the rest) name org.thisisthepy.compose.skiko: skiko-awt at the fork version. skiko-awt is a JVM jar published as a root alone, with no per-target publications, and publish-skiko-awt.sh puts it in ~/.m2. fork-dependencies.sh still asked every root sibling for a publication per served target (skiko-awt-desktop), so require-fork-artifacts.sh desktop refused a complete repository and every renderer build script stopped before the toolchain ran. A root whose metadata has no variant pointing at a target publication ("available-at") is now published when its own files are. A multiplatform root without the target's publication is still refused. fork-dependencies.test.sh covers both; the first case failed before this change with skiko-awt named as missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the renderer smoke test failing on every platform in develop CI run 43617787436 with "the measure round trip did not agree, or never ran" (iOS simulator, GraalVM Linux x64/arm64 and macOS, Windows).
Cause. #788 (FR-83, font features in Host measure) grew the measure request record from 72 to 80 bytes.
renderer/desktop/c/smoke_host.cwrites its requests by hand and kept 72, so the renderer could not read them. It is the smoke host on every platform.Fix.
MEASURE_RECORDis 80; the records are zeroed first, so the font features slot reads as none.scripts/tests/smoke-host-measure-record.test.shholds the C length equal toMEASURE_RECORD_LEN(fails on 72).Proof, GraalVM macOS renderer built from this branch, same dylib both times:
Second commit.
fork-dependencies.shasked for a per-target copy ofskiko-awt, which is one JVM jar with no per-target publications, sorequire-fork-artifacts.sh desktoprefused a complete local Maven repository and no renderer build script could start. Same commit as in #808, brought forward because local renderer builds on develop need it now; its test case fails before the fix.Not run here: the Linux, Windows and iOS smoke tests (CI).