Repository navigation
Fix: Use an if instead of continue inside run so Android compiles (FR-38, #542) - #748
Merged
Merged
Conversation
…-38, #542) Two `record.color ?: run { ...; continue }` blocks in CodeEditorModel.kt (the line and range backgrounds from #712) use continue inside an inline lambda, which the Android Kotlin compiler rejects as experimental ("break continue in inline lambdas"), so develop did not build for Android. Same behaviour, plain if. The Android build of the chat sample compiles with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop failed the Android Kotlin compile:
CodeEditorModel.kt:430: The feature "break continue in inline lambdas" is experimental. Tworecord.color ?: run { ...; continue }blocks from #712 (line and range backgrounds) becomeval color = record.color; if (color == null) { ...; continue }. Same behaviour on every target. Verified: the Android build of the chat sample (dx, arm64) compiles with exactly this change; android-kotlin copy restaged. Found while building the Flip 4 APK for #570.