Repository navigation
Conversation
…Kotlin The shared renderer Kotlin failed to compile in the Android sample build against ui and foundation 1.7.5: TextFieldBuffer.addStyle, the MultiParagraph constructor that takes Constraints and PrecomposedSlotHandle.getSize do not exist there and have no equivalent. Covers the Android build of every sample (FR-39 unaffected). Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Member
Author
Member
Author
|
Closing: superseded by #351 (Android Compose pins are at 1.9.0 on develop, and this branch conflicts with develop). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors in PR #117's 'Build the sample (Android)': CodeEditorSurface.kt:589,597 unresolved addStyle; Measurement.kt:239 no applicable MultiParagraph constructor (then lineCount, height, firstBaseline, lastBaseline, getLineLeft/Right, didExceedMaxLines, and a Double/Float mismatch at 249, all follow-ons); Measurement.kt:460 unresolved getSize.
Cause: the dx Android build compiles the shared Kotlin against androidx.compose.ui and foundation 1.7.5 (ANDROID_COMPOSE_DEPENDENCIES in compose-rust/build/renderer_dir.rs). The renderer is written against the fork (1.11), and three APIs it uses arrived after 1.7: TextFieldBuffer.addStyle, the MultiParagraph constructor taking Constraints, PrecomposedSlotHandle.getSize. The first and third have no 1.7 equivalent, so the source cannot be written around them; the pins move to 1.8.3 instead.
Behaviour is unchanged: no Kotlin source changes, desktop and iOS do not read these pins. Unverified: whether 1.8 needs a higher compileSdk than dx's default, and whether 1.8.3 has all three APIs. CI (run-heavy-ci) decides.