Skip to content

Fix: Raise the Android Compose pins to 1.8.3 - #275

Closed
b-re-w wants to merge 1 commit into
developfrom
feat/android-shared-kotlin-compat
Closed

b-re-w wants to merge 1 commit into
developfrom
feat/android-shared-kotlin-compat

Conversation

@b-re-w

@b-re-w b-re-w commented Oct 24, 2026

Copy link
Copy Markdown
Member

Errors in PR #117's 'Build the sample (Android)': CodeEditorSurface.kt:589,597 unresolved addStyle; Measurement.kt:239 no applicable MultiParagraph constructor (then lineCount, height, firstBaseline, lastBaseline, getLineLeft/Right, didExceedMaxLines, and a Double/Float mismatch at 249, all follow-ons); Measurement.kt:460 unresolved getSize.

Cause: the dx Android build compiles the shared Kotlin against androidx.compose.ui and foundation 1.7.5 (ANDROID_COMPOSE_DEPENDENCIES in compose-rust/build/renderer_dir.rs). The renderer is written against the fork (1.11), and three APIs it uses arrived after 1.7: TextFieldBuffer.addStyle, the MultiParagraph constructor taking Constraints, PrecomposedSlotHandle.getSize. The first and third have no 1.7 equivalent, so the source cannot be written around them; the pins move to 1.8.3 instead.

Behaviour is unchanged: no Kotlin source changes, desktop and iOS do not read these pins. Unverified: whether 1.8 needs a higher compileSdk than dx's default, and whether 1.8.3 has all three APIs. CI (run-heavy-ci) decides.

…Kotlin

The shared renderer Kotlin failed to compile in the Android sample build against
ui and foundation 1.7.5: TextFieldBuffer.addStyle, the MultiParagraph constructor that
takes Constraints and PrecomposedSlotHandle.getSize do not exist there and have no
equivalent. Covers the Android build of every sample (FR-39 unaffected).

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@b-re-w b-re-w added run-heavy-ci Run the heavy CI workflows on this pull request's head and removed run-heavy-ci Run the heavy CI workflows on this pull request's head labels Oct 24, 2026
@b-re-w

b-re-w commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Handoff (2026-10-25): Branch: feat/android-shared-kotlin-compat. State: open, Heavy checks is red because the heavy runs were cancelled. Next: rerun heavy (at most 2 heavy PRs at a time), then merge; then merge develop into #285, #114 and #117. Blocked on: heavy run capacity.

@b-re-w b-re-w removed the run-heavy-ci Run the heavy CI workflows on this pull request's head label Nov 5, 2026
@b-re-w

b-re-w commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Closing: superseded by #351 (Android Compose pins are at 1.9.0 on develop, and this branch conflicts with develop).

@b-re-w b-re-w closed this Nov 5, 2026
@b-re-w
b-re-w deleted the feat/android-shared-kotlin-compat branch November 12, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant