Repository navigation
Feat: Make the X11 window the Linux default, without the Windows work (NFR-14) - #172
Merged
Merged
Conversation
Linux opens the toolkit-free X11 window with no environment variable, as macOS does. Windows keeps the toolkit window and gets no-op answers for the four window calls the shared Kotlin now names. Includes the X11 key table (letters, Insert, shift+Delete as cut), CLIPBOARD and PRIMARY with middle-click paste, a paste of any size as one commit, a growing host event buffer, and the shared window shell. Docker check on Ubuntu 24.04 with Xvfb, openbox and ibus-hangul: typing, Korean, clipboard both ways, ctrl+c/v/x/z, caption and edge drag, XDND drop, a 100 KB paste. Closes #156
b-re-w
added a commit
that referenced
this pull request
Oct 4, 2026
… over the parity harness Stacked on #165. The window code is the fork's now; the Compose half of what #147 and #155 added is not, and was on neither develop nor #165. - macOS Kotlin/Native: contentMinimum, DockIcon (with ImageBitmap.toNSImage), SystemDarkMonitor fed by the appearance notification, and the fork's MacosClipboard and MacosClipboardManager, so Paste is offered by what the pasteboard holds. - GraalVM macOS: the same DockIcon, contentMinimum and a polled SystemDarkMonitor, the clipboard through TextPasteboard, window options read once by NativeWindowOptions, and the synthetic exit. - The K/N-portable LatencyTrace and SyntheticInput (no String.format, System.nanoTime shim, exit after the resize), the JvmCompatShims they need, and ParityMeasurementTest. - The hand-check app and its consumer fixture changes. Not here, with reasons: NativeWindowShell, the Win32 letter and digit keys and the default window switches depend on #134 (beginNativeWindowDrag, win32ComposeKey, the X11 and Win32 defaults, also #160, #170, #172) and come with it. The GraalVM text menu needs the fork's setTextMenu, which is not in the pinned fork commit yet. The resize header counter on Kotlin/Native is dropped: the fork's FramePresentLog replaces it. Covers FR-33.6 (clipboard and text menu enablement), FR-19 (min size, Dock icon), NFR-14.
This was referenced Oct 4, 2026
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156
Linux-only split of #160 so it no longer waits on the Windows resize work in #134. Windows keeps the toolkit window by default; only no-op stubs for the shared Kotlin's new window calls are added to win32_window.c. Docker results (Ubuntu 24.04 arm64, Xvfb, openbox, ibus-hangul): typing, Korean, CLIPBOARD and PRIMARY both ways, ctrl+c/v/x/z, shift+Insert, ctrl+Insert, shift+Delete, a 100 KB paste as one edit, caption and edge drag, XDND drop all pass. Supersedes #160.