Skip to content

Feat: Make the X11 window the Linux default, without the Windows work (NFR-14) - #172

Merged
b-re-w merged 1 commit into
developfrom
feat/linux-x11-default-only
Oct 4, 2026
Merged

b-re-w merged 1 commit into
developfrom
feat/linux-x11-default-only

Conversation

@b-re-w

@b-re-w b-re-w commented Oct 4, 2026

Copy link
Copy Markdown
Member

Closes #156

Linux-only split of #160 so it no longer waits on the Windows resize work in #134. Windows keeps the toolkit window by default; only no-op stubs for the shared Kotlin's new window calls are added to win32_window.c. Docker results (Ubuntu 24.04 arm64, Xvfb, openbox, ibus-hangul): typing, Korean, CLIPBOARD and PRIMARY both ways, ctrl+c/v/x/z, shift+Insert, ctrl+Insert, shift+Delete, a 100 KB paste as one edit, caption and edge drag, XDND drop all pass. Supersedes #160.

Linux opens the toolkit-free X11 window with no environment variable, as macOS does. Windows keeps the toolkit window and gets no-op answers for the four window calls the shared Kotlin now names. Includes the X11 key table (letters, Insert, shift+Delete as cut), CLIPBOARD and PRIMARY with middle-click paste, a paste of any size as one commit, a growing host event buffer, and the shared window shell. Docker check on Ubuntu 24.04 with Xvfb, openbox and ibus-hangul: typing, Korean, clipboard both ways, ctrl+c/v/x/z, caption and edge drag, XDND drop, a 100 KB paste.

Closes #156
b-re-w added a commit that referenced this pull request Oct 4, 2026
… over the parity harness

Stacked on #165. The window code is the fork's now; the Compose half of what #147 and #155 added
is not, and was on neither develop nor #165.

- macOS Kotlin/Native: contentMinimum, DockIcon (with ImageBitmap.toNSImage), SystemDarkMonitor
  fed by the appearance notification, and the fork's MacosClipboard and MacosClipboardManager,
  so Paste is offered by what the pasteboard holds.
- GraalVM macOS: the same DockIcon, contentMinimum and a polled SystemDarkMonitor, the
  clipboard through TextPasteboard, window options read once by NativeWindowOptions, and the
  synthetic exit.
- The K/N-portable LatencyTrace and SyntheticInput (no String.format, System.nanoTime shim,
  exit after the resize), the JvmCompatShims they need, and ParityMeasurementTest.
- The hand-check app and its consumer fixture changes.

Not here, with reasons: NativeWindowShell, the Win32 letter and digit keys and the default
window switches depend on #134 (beginNativeWindowDrag, win32ComposeKey, the X11 and Win32
defaults, also #160, #170, #172) and come with it. The GraalVM text menu needs the fork's
setTextMenu, which is not in the pinned fork commit yet. The resize header counter on
Kotlin/Native is dropped: the fork's FramePresentLog replaces it.

Covers FR-33.6 (clipboard and text menu enablement), FR-19 (min size, Dock icon), NFR-14.
@b-re-w
b-re-w merged commit 4e0844b into develop Oct 4, 2026
24 checks passed
@b-re-w
b-re-w deleted the feat/linux-x11-default-only branch October 4, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant