fix: lock host homes, align start with next on doctor FAIL - #59
Merged
Conversation
Env and host_homes paths must already exist as real directories. Absent overrides stay silent; symlink components stay fail-closed. Co-authored-by: Dandre Yang <[email protected]>
Only the constructed FAIL <kind>:<id>/<repo>: missing origin/<branch> shape matches. A path that embeds the token is not missing-origin. Co-authored-by: Dandre Yang <[email protected]>
Any doctor FAIL, including missing-origin-only, blocks dyro start and existing_line_workspace. Setup and join still skip missing-origin so a SHA-pinned local-only line can be created. Co-authored-by: Dandre Yang <[email protected]>
Replace the leaked token with the fictional example-line placeholder and scan docs for already-known banned identity tokens. Co-authored-by: Dandre Yang <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
start and next still refuse any doctor FAIL. existing_line_workspace skips missing-origin-only so a just-created local-only line can be opened; other FAILs still block open. Co-authored-by: Dandre Yang <[email protected]>
Dandre126
marked this pull request as ready for review
August 22, 2026 19:36
existing_line_workspace used a per-line prefix filter, so workspace-level FAILs such as external Profile never blocked open. Refuse the same FAIL set next maps to needs_repair, minus the constructed missing-origin shape. Co-authored-by: Dandre Yang <[email protected]>
This was referenced Aug 22, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Aug 23, 2026
把已在 main 落地的 OpenCode/Hermes Skill 分身挂接与 #59–#63 诚实收口（host-home、start/next、alias casefold、ReadBudget、 bootstrap 作用域、briefing deadline partial）收进 0.7.11。 版本停在 0.7.x，不改 0.7.10 历史，不发明新功能。 Co-authored-by: Dandre Yang <[email protected]>
Merged
Dandre126
added a commit
that referenced
this pull request
Aug 23, 2026
把已在 main 落地的 OpenCode/Hermes Skill 分身挂接与 #59–#63 诚实收口（host-home、start/next、alias casefold、ReadBudget、 bootstrap 作用域、briefing deadline partial）收进 0.7.11。 版本停在 0.7.x，不改 0.7.10 历史，不发明新功能。 Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Dandre Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial-board follow-up on
main(baseline3e24897/ post-#57), plus the P1 from the #59 review. No version bump (stays 0.7.10). Does not merge, tag, or publish.P0-1 — no host-home creation under explicit overrides
_host_homeused to return env /host_homespaths without an existence check, so_ensure_safe_directorycreated the host home andskills/.Resolved homes that are not already a real directory (not a symlink) are now skipped, matching absent-default behavior. Install refuses isolated-mirror-only when no host remains. Symlink / non-dir path components stay fail-closed. Dyro never
mkdirs host homes.P1-1 —
dyro starthonesty vs doctor FAILdyro nextalready treats any doctor FAIL (including missing-origin-only) asneeds_repair.dyro startnow refuses the same way.P1-2 — parse missing-origin findings
is_missing_origin_findingnow matches the constructed doctor shapeFAIL <kind>:<id>/<repo>: missing origin/<branch>instead of a substring. A FAIL whose path embeds: missing origin/evilis not classified as missing-origin and still blocks start.P1-3 — public review redaction
The public 2026-08-19 slash-review record now uses the fictional
example-lineplaceholder.docs/is scanned for already-known banned identity tokens only.P1 — open exception is missing-origin-only (review of this PR)
existing_line_workspaceused a per-line prefix filter, so workspace-level FAILs such asFAIL external Profile requires …never blocked open while start/next refused.Open now refuses every doctor FAIL that
nextmaps toneeds_repair, except the constructed missing-origin shape. Setup / join / open may skip only that shape so a just-created local-only line can be created and opened. Every other FAIL blocks open.Tests
host_homespointing at a missing path: path is not created; install refuses creating it.dyro startrefuses missing-origin-only and path-embedded-token FAILs.: missing origin/evilin a path.needs_repair; missing-origin-only local-only open still works.CHANGELOG Unreleased notes the live contract. Version pins stay 0.7.10.