Skip to content

Removed ancient custom locatins of openssl libs#251

Merged
jwillemsen merged 2 commits into
DOCGroup:masterfrom
jwillemsen:jwi-openssllibpaths
Jul 22, 2026
Merged

Removed ancient custom locatins of openssl libs#251
jwillemsen merged 2 commits into
DOCGroup:masterfrom
jwillemsen:jwi-openssllibpaths

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Jul 22, 2026

Copy link
Copy Markdown
Member
* config/openssl.mpb:

Summary by CodeRabbit

  • Bug Fixes
    • Improved OpenSSL configuration compatibility by removing outdated, toolchain-specific library search paths.
    • Preserved existing handling for platform-specific include and library locations.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jwillemsen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd06b07b-dcc2-4816-ba14-72ade32d720a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f87cc4 and 8049924.

📒 Files selected for processing (1)
  • config/openssl.mpb

Walkthrough

The OpenSSL feature configuration removes Borland- and Microsoft-specific library search path overrides while preserving the existing non-Windows and CMake handling.

Changes

OpenSSL configuration

Layer / File(s) Summary
Remove toolchain-specific library paths
config/openssl.mpb
Deletes the additional Builder5 and VC library directories for Borland and Microsoft toolchains.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny with paths in my nest,
Two old library trails laid to rest.
Borland hops by, Microsoft too,
CMake keeps its familiar view.
Clean config makes carrots grow—
Hop, hop, onward we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by describing the removal of old custom OpenSSL library locations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

    * config/openssl.mpb:
@jwillemsen
jwillemsen merged commit 420e247 into DOCGroup:master Jul 22, 2026
12 checks passed
@jwillemsen
jwillemsen deleted the jwi-openssllibpaths branch July 22, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant