Skip to content

Fixed missing member offset verification in CCamScriptInstruction #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gennariarmando merged 1 commit into from
Aug 9, 2026
Merged

Fixed missing member offset verification in CCamScriptInstruction #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions plugin_IV/game_IV/CCamScriptInstruction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
class CCamScriptInstruction {
public:
uint8_t field_1;
#ifndef _MSC_VER
uint8_t _pad_abi[3]; // Fill tail padding (Itanium ABI compatibility)
#endif
uint8_t pad[3]; // Fill tail padding (Itanium ABI compatibility)

public:
CCamScriptInstruction() {
Expand All @@ -28,6 +26,7 @@ class CCamScriptInstruction {
void SetInstruction(CCamScriptInstruction* instruction);
};
VALIDATE_OFFSET(CCamScriptInstruction, field_1, 0x4);
VALIDATE_OFFSET(CCamScriptInstruction, pad, 0x5);
VALIDATE_SIZE(CCamScriptInstruction, 0x8);

class CCamScriptInstruction_SetCamBehindPed : public CCamScriptInstruction {
Expand Down