Skip to content

preliminary feedback  #40

Description

@davidchampredon

After taking a first stab at playing with the package, here are my initial comments :

  • remove duplicate title in README
  • increment version number as needed (this may be helpful especially in this development phase)
  • add clear (could be brief) documentation for functions mentioned in the README file (parse_mutations, get_mutation_defs, ...)
  • give an example of how we can see the variant matrix used, how we can create/modify one (get_mutation_defs(res))
  • x-axis in autoplot(..., date_col = 'date') gets busy when large number of dates. Consider defaulting to weekly or monthly based on the date range of the data plotted.
  • is there a check of the variant matrix if two definitions are equivalent? for example one defining the mutation in terms of nucleotides and the other in terms of AA.
  • hide internal functions from the package documentation
  • give example that calculates the confidence intervals

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions