Repository navigation
Drive Kiralux through PyHardwareLibrary's USBPort (option B) - #1
Merged
Merged
Conversation
…usb1 Transport-only change — the API (snap() -> PolarFrame, properties) is identical. Command dialog uses USBPort.writeData/readData on EP 0x02/0x82; the image uses USBPort.readStream on EP 0x83 (the high-throughput bulk read added in DCC-Lab/PyHardwareLibrary#120). Verified on hardware: full 2448x2048 frame, vmed 3 (clean), ~61 MB/s. Requires hardwarelibrary (master + PR #120). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Cwn4LmnBsBpXbQKRh6ByZr
…eleased in 2.2.0) Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Cwn4LmnBsBpXbQKRh6ByZr
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Cwn4LmnBsBpXbQKRh6ByZr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport-only variant:
macos/kiralux.pyis rebuilt on PyHardwareLibrary'sUSBPortinstead of the privateusb1transport. The high-level API is unchanged —snap()still returns aPolarFramewith.s0/.dolp/.aolp, and all the properties (exposure_us,roi,binning, …) work as before.USBPort.writeData/readDataon EP0x02/0x82(endpoints resolved by address viaendPointForAddress).USBPort.readStreamon EP0x83, the high-throughput bulk read added in USBPort: high-throughput readStream(), serial matching, endpoint-by-address PyHardwareLibrary#120.Verified on hardware (Kiralux CS505MUP1): full 2448×2048 frame,
vmed 3(clean), ~61 MB/s.Requires
hardwarelibrary(master + PR #120 forreadStream):pip install "git+https://github.com/DCC-Lab/PyHardwareLibrary@improve-usbport-streaming"masterkeeps the dependency-freeusb1driver; this branch is the ecosystem-aligned alternative. Depends on #120 being merged first.🤖 Generated with Claude Code