fix(call): match mute/unmute keywords as whole words - #408
Open
noelpatata wants to merge 1 commit into
Open
noelpatata wants to merge 1 commit into
noelpatata wants to merge 1 commit into
Conversation
matchesActionKeyword compared the title against " " instead of the keyword, so only an exact "Mute" label counted: multi-word labels such as "Mute microphone" were never a microphone control (no connected-controls transition to ACTIVE), and any label with a leading or trailing space was read as Mute/Unmute. Match the keyword as a whole word anywhere in the title; "Unmute" still never matches "mute". Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallNotificationClassifier.matchesActionKeywordcheckedstartsWith(" ")/endsWith(" ")instead of the keyword, so:Mutelabel was recognised: multi-word labels like "Mute microphone" or "Tap to mute" were never a microphone control, so theconnected-controls-transitionto ACTIVE couldn't fire for apps that label it that wayNow the keyword is matched as a whole word anywhere in the label ("Unmute" still never matches
mute).Might be part of the "stuck on Calling" reports (#387, #226), but I can't confirm without the real Instagram/Messenger action labels, so not marking them as fixed.
Tests: 3 new (fail on the old code), full suite 422/422, assembleDebug OK.
🤖 Generated with Claude Code