fix: ensure small and big island visibility on HyperOS 4 Beta by setting dismissible to false - #393
Merged
Merged
Conversation
📱 Debug APK Ready for TestingThe debug APK for commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357
Summary
Fixes an issue reported on HyperOS 4 Beta where the Dynamic Island (both small pill and expanded big island) failed to show for Standard, Message, and Dynamic notification types, while other translators (such as Media and Call) worked without issues.
Investigation & Root Cause
StandardTranslatorandMessageTranslatoragainst working translators likeMediaTranslator, we isolated thatMediaTranslatorran withdismissible = false, whereasStandardTranslator,MessageTranslator, andDynamicTranslatorpasseddismissible = trueinsetIslandConfig(...)."dismissIsland": truein theparam_islandpayload causes the system to skip showing the Island UI for these non-ongoing / transient notifications.Changes
dismissible = falseinsetIslandConfig(...)for:StandardTranslatorMessageTranslatorDynamicTranslatordismissible = falseis required for HyperOS 4 compatibility.dismissible = trueintact for completed states inDownloadTranslatorandProgressTranslatorwhere it is still working as intended.Verification
./gradlew compileDebugKotlin.