Repository navigation
fix(standards): wrong license-check names, copy-pasted log text, severities - #915
Merged
Merged
Conversation
…rities - Test-CIPPStandardLicense -StandardName pointed at another standard in AutoAddProxy, GlobalQuarantineSettings, RestrictThirdPartyStorageServices, SharePointMassDeletionAlert, ExchangeConnectorTemplate - DisableEntraPortal alert/report checked isSoftwareOathEnabled (copied from SoftwareOath) instead of restrictNonAdminAccess - log messages naming the wrong standard in 5 standards - -sev Warn -> Warning (10 sites), 'Information' -> 'Info' - ListLogs: severity filter "Warn" now also matches "Warning" rows - ExecExtensionSync NinjaOne failure logged as Scheduler_Billing; InactiveUsers alert message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy-paste errors in standards and alerts.
Test-CIPPStandardLicense. "License Missing" was written onto the wrong standard (e.g. AutoAddProxy flagged AutoArchive) and the real one showed nothing.isSoftwareOathEnabled, copied from SoftwareOath, while remediate setsrestrictNonAdminAccess.Warnis used 10 times andWarning527 times, so the 10 are normalised toWarning. The logs page "Warning" filter sendsWarnand ListLogs matches exactly, so it has always missedWarningrows. ListLogs now expandsWarnto includeWarning.Scheduler_BillingAPI name, and an alert message was copy-pasted from InactiveLicensedUsers.Testing