Repository navigation
fix: Resolve iOS compilation failure by adding missing ktor-network dependency - #50
huytran2005 wants to merge 1 commit into
Conversation
…EscPosPrinterClient Co-authored-by: huytran2005 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|



Problem Statement
The iOS target compilation failed during CI/CD (
./gradlew check) due to unresolved Ktor network references inTcpRawEscPosPrinterClient.kt(e.g.,SelectorManager,Socket,aSocket,openWriteChannel, etc.). The root cause was thatktor-networkwas completely missing from the multiplatform common dependencies block, leading to compilation errors on non-Android targets since they lack the default JVM networking fallback the Android target silently provided.Summary of Changes
ktor-network(io.ktor:ktor-network) togradle/libs.versions.toml.implementation(libs.ktor.network)to thecommonMaindependencies block inshared/build.gradle.kts.TcpRawEscPosPrinterClientTest.ktto explicitly verify timeout handling behavior to improve code coverage per quality standards.Verification Results
Ran
./gradlew testand./gradlew check. All 78 tasks executed successfully and the iOS simulator target successfully compiledTcpRawEscPosPrinterClient.ktwithout unresolved reference errors.Residual Limitations
Due to the multiplatform nature, robustly testing raw TCP socket behaviors in KMP common test environments is difficult without a mock local TCP server. The current test verifies timeout behavior against unreachable hosts (
TEST-NET-1). Additional manual testing on real hardware against physical ESC/POS printers is recommended.PR created automatically by Jules for task 4752608252615182327 started by @huytran2005