Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Staff Details goal settings showed Coach, Coordinator, Training and Ministry as hardcoded text
("Amy Wilson", "Fall NSO 2026", "Campus: University", three invented coordinator names). This
replaces all four with the household's real values, and makes the coach assignable, changeable and
removable from the page.
newStaffCohortAttendeewith the goal calculation. It is null for scenario goals and foranyone outside the MPD Goals team, so the staff member's own wizard, which shares this query
document, is unaffected.
are owned by the attendee and OneApp.
AssignCoachModal,so both places offer the same list, and it loads lazily since most visits never open it. Remove
asks for confirmation first and says the coach loses access to the account.
GoalSettingsPlaceholderis renamed toGoalSettingsReadOnlyField. Same UI, but it is no longer astand-in for missing data, so its docstring no longer says it is one.
Depends on CruGlobal/mpdx_api#3601. That PR adds
newStaffCohortAttendee,cohortName,newStaffCohortId, theattendeeIdargument onnewStaffCohortAssignableCoachesand theunassignCoachFromNewStaffCohortAttendeemutation. Codegen resolves the schema from the API, soCI here will fail until #3601 is merged and deployed to staging. Do not merge before then.
Testing
Checklist:
/quality:agent-reviewcommand locally and fixed any relevant suggestions