[MPDX-9970] Show users their gross requested YTD salary and pending ASR information - #2021
Open
canac wants to merge 3 commits into
Open
[MPDX-9970] Show users their gross requested YTD salary and pending ASR information#2021canac wants to merge 3 commits into
canac wants to merge 3 commits into
Conversation
canac
added
Preview Environment
Contributor
|
Preview branch generated at https://9970-asr-ytd.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against 914884c No significant changes found |
pendingAsrAmount has always held the year's entire ASR total — pending, action required, approved, and paid alike — so the name implied the opposite of what it returned. The API now exposes it as ytdAsrAmount and keeps pendingAsrAmount only as a deprecated alias. The salary calculation request reads ytdAsrAmount directly rather than subtracting requestedGross from requestedYtdGross. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the ASR and salary request page, show the user their gross requested YTD salary (which includes ASRs this year) so when they exceed their cap it is clearer why.
Depends on new server fields added in https://github.com/CruGlobal/mpdx_api/pull/3585
Testing
Checklist:
/quality:agent-reviewcommand locally and fixed any relevant suggestions