MPDX-9751 Monthly summary chart view

[kegrimes]

Description

In the MPD Supervisors report, we want to add a chart view alongside the table view in the monthly summary tab that users can toggle between.

Jira ticket: MPDX-9751

Testing

MPD supervisor test:

• Go to /hrTools/mpdSupervisorReport
• Click on an employee and go to "Monthly Summary" tab
• Check that the table is present with toggle buttons at the top
• Click on the chart view
• Check that the chart is present with correct data

MPGA test:

• Go to /reports/mpgaIncomeExpenses
• Ensure nothing broke here

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /quality:agent-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Preview branch generated at https://mpdx-9751-monthly-summary-chart-view.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 914884c

Route	Size (gzipped)	Diff
/accountLists/[accountListId]/hrTools/mpdSupervisorReport	241.63 KB	+100.99 KB

[kegrimes]

Multi-Agent Code Review (agent-review, standard mode)

5 specialized agents (Architecture, Testing, Standards, Financial Reporting, UX) plus a dependency-impact pass and a targeted gap review, with a full cross-examination debate round.

Verdict: APPROVED WITH SUGGESTIONS

No blockers. Nothing survives debate above severity 6.8, and this PR touches zero auth/security/migration/GraphQL surface — every finding is display-layer. The mechanical risk score below (10/10) is a file-count artifact of touching 7 medium-risk files across two feature areas; it does not reflect actual risk here.

Top 3 things worth doing before/soon after merge:

1. WCAG contrast regression — chipGreenDark/chipRedDark fail AA as table text (2.78:1 / 3.68:1) where success.main/error.main passed (5.13:1 / 4.98:1).
2. Toggle/content desync — clicking "Chart view" with zero rows leaves the table on screen while the toggle claims Chart is selected.
3. Misplaced hook + component — useMonthlySummaryChartData can only run inside one feature's context, and MonthlySummaryChart is now reached into cross-feature without living in a shared location.

All 16 existing/updated tests pass. No breaking changes found by the dependency-impact pass (all 3 real call sites of MonthlySummaryChart were updated correctly).

Inline comments below carry a machine-readable severity tag. Reply /dismiss: <reason> on any comment tagged severity < 7 if you disagree — severity ≥ 7 findings can't be dismissed (there are none in this review).

[kegrimes]

@wjames111 Looking for a quick glance at this PR! I couldn't get the approval (it was ranked as Critical)

[wjames111]

Did a quick skim and tested, looks good to me! UI is looking great on Supervisor Report