fix: bump @hono/node-server to fix Node 24 'Failed to find Response internal state key' - #38
Draft
linus-codes[bot] wants to merge 1 commit into
Draft
fix: bump @hono/node-server to fix Node 24 'Failed to find Response internal state key'#38linus-codes[bot] wants to merge 1 commit into
linus-codes[bot] wants to merge 1 commit into
Conversation
…nternal state key'
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ANY-6889.
Every boot of the gateway on Node 24 prints
Failed to find Response internal state key(visible in escher local dev asportkey: Failed to find Response internal state keyvia the compose service prefix).@hono/[email protected]predates undici's Node 24 change to Response internal state (known upstream: Portkey-AI#1604, fixed in node-server 1.14.2 via honojs/node-server#241 — upstream's own bump PR is unmerged, so thepatchedbranch never inherited it). Besides the log noise, the missing state key disables node-server's fast Response path and is the defect behind upstream's reported intermittent Node 24 crashes.One-line fix:
@hono/node-server^1.3.3(locked 1.13.5) →^1.19.17. npm also canonically re-sorted two adjacent dep lines; the lockfile diffs as binary per this repo's.gitattributes.Verified on Node v24.18.0 (same major as the
node:24-alpineprod image):Responsethroughserve().npm run buildgreen;node build/start-server.js --headlessboots to ready with zero occurrences.requestContextsuite differential vs untouchedpatched: identical results (2 pre-existing ambient failures, 53 passed) — the bump changes no test outcome. The other red suites are ambient onpatched(stalejest.mockpaths, plugin tests needing live external services).After merge: escher
apps/shared/portkeypin bump to the squash commit follows as its own PR.