test: add Ruby x Rails test matrix via Appraisal + GitHub Actions#40
Merged
Conversation
- Appraisals + gemfiles/ for Rails 7.2, 8.0, 8.1 - .github/workflows/ruby.yml matrix: Ruby 3.1-3.4 x Rails 7.2/8.0/8.1 (Ruby 3.1 excluded on Rails 8.x, which requires Ruby >= 3.2) - gemspec: add appraisal; swap unmaintained coveralls -> coveralls_reborn (the old gem pins an ancient simplecov and breaks resolution on newer Ruby) - Only rails (activesupport + railties) is pinned per gemfile; no DB, so no rspec-rails/sqlite unlike userstamp - Fix stale Python 3.14 spec: dependency is 'formulas[excel]', not 'formulas' - test: assert docker_image returns nil when unset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the matrix exercises Language as a PORO. In the main app Language is
an ActiveRecord model (see lib/extensions/polyglot_with_database there), so
a green matrix here does not cover the production path -- run the main app's
polyglot specs when validating a Rails upgrade.
An unset docker_image now intentionally returns nil (marking a language as
not runnable, e.g. a deprecated one) rather than deriving a name from the
class. Update the specs to the new contract: drop the obsolete
auto-generation cases and assert nil for concrete languages declared without
an explicit docker_image. The auto-generation method in ClassMethods is left
in place for now.