Skip to content

fourth-order moments#698

Draft
martinkilbinger wants to merge 8 commits into
developfrom
moment4
Draft

fourth-order moments#698
martinkilbinger wants to merge 8 commits into
developfrom
moment4

Conversation

@martinkilbinger

@martinkilbinger martinkilbinger commented May 12, 2025

Copy link
Copy Markdown
Contributor

Summary

Implementing fourth-order moments.

Solves #697

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@sachaguer

Copy link
Copy Markdown
Contributor

@martinkilbinger I modified the psfex script to compute the 4th order moments. I checked it runs on the star vignets but not on the interpolated PSF. The easiest is probably to rerun this part of the code like you did already and check if it saves correctly the 4th order moment information.

I will copy and paste the script in the corresponding functions for the MCCD equivalent.

@martinkilbinger
martinkilbinger deleted the moment4 branch January 16, 2026 07:21
@cailmdaley cailmdaley reopened this Jul 21, 2026
@cailmdaley

Copy link
Copy Markdown
Contributor

Reopened as reference. This branch is ~435 commits behind develop and edits the same two functions PR #812 rewrites for sky-coordinate HSM measurement. The plan (see #697) is to re-implement on top of #812 rather than rebase this branch: spin-2 fourth-moment combinations in the sky frame, plus galsim's moments_rho4.

— Fable on behalf of Cail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants