chore(summary): drop --fix-first and --held, which nothing reads - #55
Merged
Merged
Conversation
Both flags survived the cascade that gave them meaning. --held marked a cheap pass withholding a strong review, and --fix-first let the blocking count follow the fix-first set on such a run, because block-on need not contain those severities. There is no withholding and no tier line any more, so the count has followed block-on alone for some time — while the two flags went on being parsed, and --fix-first went on being validated, with neither value read by anything downstream. fix-first REMAINS an action input. It stops the exhaustive loop early (action.yml), which is a different question from what the summary counts; the header now says so, so the name cannot argue its way back into this count later. Removing a flag the script no longer understands is safe to ship on its own: the argument loop has no else branch, so an unrecognised flag and the value after it are skipped one token at a time without shifting the flags that follow. The surviving block-on test now passes --fix-first in the MIDDLE of the argv to hold that property down. Also scopes the action-inputs reference to this action: the hosted App runs a different review engine, so fix-first and exhaustive can behave differently there, and the file now says to answer App questions from the console instead. Test suite is unchanged by this: 558 pass / 9 fail before and after, the failures being a pre-existing CRLF mismatch in the action.yml input tests on a Windows checkout. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Contributor
Author
|
@codex review |
Contributor
Author
|
@orcacode-review |
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 164 calls · 4M tokens · 92% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
summary-comment.mjsparses two flags that nothing downstream reads.Both survived the cascade that gave them meaning.
--heldmarked a cheap pass withholding a strong review, and--fix-firstlet the blocking count follow the fix-first set on such a run — becauseblock-onneed not contain those severities, and "❌ 0 findings block merge" beside a held tier line contradicts itself.There is no withholding and no tier line any more, so the count has followed
block-onalone for some time. Meanwhile--heldwas still parsed intoopts.held, and--fix-firstwas still parsed and validated againstSEVERITIES, with neither value read anywhere after that.fix-firstthe input is untouchedIt stops the exhaustive loop early (
action.yml), which is a different question from what this summary counts. The header now says so explicitly, so the shared name cannot argue its way back into the count later.Safe to ship on its own
The argument loop has no
elsebranch, so an unrecognised flag — and the value after it — are skipped one token at a time without shifting the flags that follow. The surviving block-on test now passes--fix-first P0in the middle of the argv rather than at the end, which turns that property into a regression guard instead of an assumption.Docs
skills/orca-review-action/references/inputs.mdnow scopes itself to this action. The hosted GitHub App runs a different review engine, so a setting of the same name can behave differently there —fix-firstandexhaustivein particular — and the file says to answer App questions from the console rather than from these rows.Verification
npm test: 558 pass / 9 fail before this change, and 558 pass / 9 fail after — byte-identical counts. The 9 are a pre-existing CRLF mismatch in theaction.ymlinput assertions on a Windows checkout, unrelated to these files.🤖 Generated with Claude Code