Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,7 @@ Optimized metric route processing to O(N) by creating a mapping of routes direct
## 2024-07-13 - [Optimize Export Dictionary FK lookups]
**Learning:** Found O(N * C * E) performance bottleneck in ERD export dictionaries due to repeated array searching with `edges.some()` inside a nested loop over nodes and columns.
**Action:** Replace repeated linear array scans for edges by precomputing O(1) Set lookups of foreign key column handles per node before looping.

## 2024-08-17 - Optimize Array.from for GC Overhead in sanitizeHandleId
**Learning:** Using `Array.from(string)` to iterate over strings creates intermediate array allocations, increasing garbage collection overhead. In hot paths like frontend ERD graph processing (`sanitizeHandleId` in `handleUtils.ts`), removing these allocations provides a measurable performance improvement.
**Action:** Replace `Array.from()` with an iterative `for...of` loop in high-frequency string processing functions to avoid intermediate array instantiation and reduce GC pressure.
21 changes: 14 additions & 7 deletions frontend/src/erd/handleUtils.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
export function sanitizeHandleId(columnName: string): string {
const encoded = Array.from(columnName, (char) => {
// Array.from only yields non-empty Unicode scalars, so codePointAt(0) is defined.
return char.codePointAt(0)!.toString(16).padStart(4, '0')
}).join('-')
if (!columnName) return 'c-empty';

return `c-${encoded || 'empty'}`
let encoded = '';
let isFirst = true;
for (const char of columnName) {
if (!isFirst) {
encoded += '-';
}
encoded += char.codePointAt(0)!.toString(16).padStart(4, '0');
isFirst = false;
}

return `c-${encoded}`;
}

export function sourceColumnHandleId(columnName: string): string {
return `src-${sanitizeHandleId(columnName)}`
return `src-${sanitizeHandleId(columnName)}`;
}

export function targetColumnHandleId(columnName: string): string {
return `tgt-${sanitizeHandleId(columnName)}`
return `tgt-${sanitizeHandleId(columnName)}`;
}
Loading